-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add visible option to panels #2989
feature: add visible option to panels #2989
Conversation
Code Climate has analyzed commit a84b924 and detected 0 issues on this pull request. View more on Code Climate. |
Ayy, my first collaboration! |
Hello @icaroryan you made it! Thanks for the contribution, it's looking good. Most Avo test files are under the We have this test that already checks the visibility of tabs, panels, and the sidebar. The purpose of this test is to ensure that none of these elements are rendered if their respective fields are hidden. You can add a test case for panel visibility block inside it. |
Thank you @Paul-Bob! Just pushed the new tests. I tried to follow the same structure of the existing ones |
569c94f
to
c1079ec
Compare
With that being said, I think it’s worth having the same option for tab. If you give me the go-ahead, I can push a PR for it. It would be basically the same thing we did with panels. |
c1079ec
to
74e3b86
Compare
Looking great, Thanks! DOCS PR (just to remain linked): avo-hq/docs.avohq.io#248
I would be happy to merge it, thanks for the initiative, we appreciate it! |
Description
This PR adds a
visible
option to Panels, which should hide all the contained fields as well as the panel.This new option shouldn't affect
main_panel
onlypanel
Fixes #https://github.com/avo-hq/avo/issues/2971
Checklist:
Screenshots & recording
Screen.Recording.2024-07-15.at.10.15.21.AM.mov
Manual review steps
visible: -> { false }
to a panelmain_panel
Manual reviewer: please leave a comment with output from the test if that's the case.